Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2020-8908: upgrade guava #7523

Merged
merged 1 commit into from Oct 13, 2021
Merged

Conversation

dhalperi
Copy link
Member

We actually are not affected by this bug, but may as well
get it off the warnings dashboard.

@batfish-bot
Copy link

This change is Reviewable

@dhalperi dhalperi force-pushed the upgrade-guava branch 2 times, most recently from 1761151 to 1398626 Compare October 13, 2021 17:59
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #7523 (34335a4) into master (c08abcd) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7523      +/-   ##
============================================
- Coverage     73.45%   73.44%   -0.02%     
+ Complexity    41039    41028      -11     
============================================
  Files          3252     3252              
  Lines        162396   162396              
  Branches      19517    19517              
============================================
- Hits         119293   119268      -25     
- Misses        33724    33751      +27     
+ Partials       9379     9377       -2     
Impacted Files Coverage Δ
...amodel/routing_policy/expr/DestinationNetwork.java 60.00% <0.00%> (-20.00%) ⬇️
.../datamodel/routing_policy/statement/SetMetric.java 60.86% <0.00%> (-17.40%) ⬇️
.../datamodel/routing_policy/expr/DiscardNextHop.java 33.33% <0.00%> (-16.67%) ⬇️
...ish/datamodel/routing_policy/statement/SetTag.java 54.16% <0.00%> (-16.67%) ⬇️
...n/java/org/batfish/common/topology/Layer2Edge.java 45.16% <0.00%> (-12.91%) ⬇️
...tamodel/routing_policy/expr/LegacyMatchAsPath.java 68.75% <0.00%> (-6.25%) ⬇️
.../datamodel/routing_policy/expr/MatchPrefixSet.java 68.18% <0.00%> (-4.55%) ⬇️
...l/routing_policy/statement/SetLocalPreference.java 69.56% <0.00%> (-4.35%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...batfish/datamodel/routing_policy/statement/If.java 87.20% <0.00%> (-1.17%) ⬇️
... and 5 more

We actually are not affected by this bug, but may as well
get it off the warnings dashboard.

Upgraded errorprone-annotations
Removed eclipse guava support
Prevent a junit upgrade from guava-testlib
Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 9 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 6acbf96 into batfish:master Oct 13, 2021
@dhalperi dhalperi deleted the upgrade-guava branch October 13, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants