Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BgpRib question: Add received from IP #7781

Merged
merged 4 commits into from
Dec 13, 2021
Merged

BgpRib question: Add received from IP #7781

merged 4 commits into from
Dec 13, 2021

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Dec 10, 2021

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 4 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #7781 (9220e73) into master (08ae55d) will decrease coverage by 0.01%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##             master    #7781      +/-   ##
============================================
- Coverage     73.92%   73.90%   -0.02%     
+ Complexity    42042    42033       -9     
============================================
  Files          3302     3302              
  Lines        165607   165621      +14     
  Branches      19835    19837       +2     
============================================
- Hits         122418   122404      -14     
- Misses        33686    33704      +18     
- Partials       9503     9513      +10     
Impacted Files Coverage Δ
...org/batfish/question/routes/RouteRowAttribute.java 78.84% <83.33%> (+0.27%) ⬆️
...va/org/batfish/question/routes/RoutesAnswerer.java 89.16% <100.00%> (+0.16%) ⬆️
...rg/batfish/question/routes/RoutesAnswererUtil.java 92.00% <100.00%> (+0.08%) ⬆️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-5.96%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 80.23% <0.00%> (-2.33%) ⬇️
...model/routing_policy/communities/CommunitySet.java 93.84% <0.00%> (-1.54%) ⬇️
...ain/java/org/batfish/datamodel/EvpnType3Route.java 70.96% <0.00%> (-1.08%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.48% <0.00%> (-0.86%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
... and 2 more

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@ratulm ratulm merged commit fb08932 into master Dec 13, 2021
@ratulm ratulm deleted the bgp-receivedfrom branch December 13, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants