Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA: improve dependence tracking for named interfaces #7810

Merged
merged 1 commit into from Dec 15, 2021

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #7810 (1e1440c) into master (78c4040) will decrease coverage by 0.00%.
The diff coverage is 69.23%.

@@             Coverage Diff              @@
##             master    #7810      +/-   ##
============================================
- Coverage     73.93%   73.93%   -0.01%     
- Complexity    42067    42074       +7     
============================================
  Files          3304     3304              
  Lines        165723   165748      +25     
  Branches      19854    19862       +8     
============================================
+ Hits         122534   122551      +17     
- Misses        33677    33680       +3     
- Partials       9512     9517       +5     
Impacted Files Coverage Δ
...ish/representation/cisco_asa/AsaConfiguration.java 52.08% <69.23%> (+0.20%) ⬆️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...batfish/representation/aws/LoadBalancerTarget.java 54.16% <0.00%> (-4.17%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 80.23% <0.00%> (-2.33%) ⬇️
...main/java/org/batfish/datamodel/acl/AclTracer.java 63.69% <0.00%> (-1.28%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.48% <0.00%> (-0.61%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.16% <0.00%> (-0.53%) ⬇️
...batfish/dataplane/protocols/BgpProtocolHelper.java 92.47% <0.00%> (-0.47%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 50.42% <0.00%> (-0.43%) ⬇️
...resentation/cisco_nxos/CiscoNxosConfiguration.java 88.13% <0.00%> (-0.18%) ⬇️
... and 11 more

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi merged commit 0a84dd2 into batfish:master Dec 15, 2021
@dhalperi dhalperi deleted the asa branch December 15, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants