Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-XR: fix and test v6 and v4 acls fighting on interfaces #7827

Merged
merged 2 commits into from Dec 17, 2021

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #7827 (0f79505) into master (f2e0143) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7827      +/-   ##
============================================
- Coverage     73.96%   73.96%   -0.01%     
+ Complexity    42094    42090       -4     
============================================
  Files          3305     3305              
  Lines        165872   165880       +8     
  Branches      19868    19870       +2     
============================================
- Hits         122695   122685      -10     
- Misses        33651    33663      +12     
- Partials       9526     9532       +6     
Impacted Files Coverage Δ
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java 42.91% <100.00%> (-0.09%) ⬇️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 80.23% <0.00%> (-2.33%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...main/java/org/batfish/datamodel/acl/AclTracer.java 63.69% <0.00%> (-1.28%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.48% <0.00%> (-0.86%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.80% <0.00%> (-0.16%) ⬇️
.../org/batfish/vendor/sonic/representation/Port.java 100.00% <0.00%> (ø)
...g/batfish/vendor/sonic/representation/MgmtVrf.java 95.65% <0.00%> (ø)
... and 4 more

@dhalperi dhalperi merged commit c5ea2e3 into batfish:master Dec 17, 2021
@dhalperi dhalperi deleted the xr-acls branch December 17, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants