Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IP filtering of IP-owners #7888

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Enable IP filtering of IP-owners #7888

merged 2 commits into from
Jan 4, 2022

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Jan 4, 2022

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #7888 (869b682) into master (0cc0847) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff            @@
##             master    #7888   +/-   ##
=========================================
  Coverage     74.14%   74.14%           
- Complexity    42437    42461   +24     
=========================================
  Files          3327     3327           
  Lines        166910   166941   +31     
  Branches      19971    19979    +8     
=========================================
+ Hits         123748   123783   +35     
+ Misses        33601    33595    -6     
- Partials       9561     9563    +2     
Impacted Files Coverage Δ
...rg/batfish/question/ipowners/IpOwnersAnswerer.java 54.05% <78.94%> (-4.77%) ⬇️
...rg/batfish/question/ipowners/IpOwnersQuestion.java 80.00% <80.00%> (-3.34%) ⬇️
...fish/question/ipowners/IpOwnersQuestionPlugin.java 66.66% <100.00%> (ø)
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.69% <0.00%> (-0.16%) ⬇️
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 78.17% <0.00%> (+0.24%) ⬆️
...ain/java/org/batfish/storage/FileBasedStorage.java 86.09% <0.00%> (+0.60%) ⬆️
...representation/cisco_nxos/BgpVrfConfiguration.java 61.42% <0.00%> (+6.74%) ⬆️

Copy link
Contributor

@anothermattbrown anothermattbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@ratulm ratulm merged commit e8a6d5b into master Jan 4, 2022
@ratulm ratulm deleted the ipowners-ipfiltering branch January 4, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants