Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXOS: access VLANs must be configured & active #7953

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Conversation

corinaminer
Copy link
Contributor

The CLI will allow you to configure access VLANs that are inactive or not configured.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #7953 (284bf3d) into master (f95e52d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7953      +/-   ##
============================================
- Coverage     74.27%   74.26%   -0.01%     
+ Complexity    42727    42721       -6     
============================================
  Files          3338     3338              
  Lines        167698   167699       +1     
  Branches      20074    20075       +1     
============================================
- Hits         124555   124539      -16     
- Misses        33543    33554      +11     
- Partials       9600     9606       +6     
Impacted Files Coverage Δ
...resentation/cisco_nxos/CiscoNxosConfiguration.java 88.19% <100.00%> (+<0.01%) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 55.95% <0.00%> (-4.77%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 80.23% <0.00%> (-2.33%) ⬇️
...model/routing_policy/communities/CommunitySet.java 93.84% <0.00%> (-1.54%) ⬇️
...ain/java/org/batfish/datamodel/EvpnType3Route.java 70.70% <0.00%> (-1.02%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.48% <0.00%> (-0.61%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.53% <0.00%> (-0.16%) ⬇️

@corinaminer corinaminer merged commit ef252a6 into master Jan 18, 2022
@corinaminer corinaminer deleted the nxos-access-vlans branch January 18, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants