Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HSRP properties question #7967

Merged
merged 2 commits into from Jan 22, 2022
Merged

Conversation

arifogel
Copy link
Member

  • copied from VRRP properties question, except:
    • slightly simpler implementation for populating virtual addresses in answer due to simpler model
      of HsrpGroup vs VrrpGroup

- copied from VRRP properties question, except:
  - slightly simpler implementation for populating virtual addresses in answer due to simpler model
    of HsrpGroup vs VrrpGroup
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @corinaminer)

a discussion (no related file):
FYI this is likely to cause doc failures in pybatfish. Be prepared :)


Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @corinaminer)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@arifogel arifogel merged commit 06c5879 into batfish:master Jan 22, 2022
@arifogel arifogel deleted the ari-hsrp-properties branch January 22, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants