Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions for a few Junos applications #8007

Merged
merged 2 commits into from Feb 4, 2022
Merged

Add definitions for a few Junos applications #8007

merged 2 commits into from Feb 4, 2022

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Feb 4, 2022

Add definitions for junos-{nbds,nbname,tftp}

Add new applications junos-stun-{tcp,udp} and convert junos-stun to an application-set.

Fixes #8003

@batfish-bot
Copy link

This change is Reviewable

@ratulm ratulm requested a review from arifogel February 4, 2022 08:13
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #8007 (8f60bf9) into master (4c3b57c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8007      +/-   ##
============================================
- Coverage     74.31%   74.30%   -0.01%     
- Complexity    42874    42877       +3     
============================================
  Files          3347     3347              
  Lines        168135   168162      +27     
  Branches      20148    20150       +2     
============================================
+ Hits         124942   124956      +14     
- Misses        33597    33607      +10     
- Partials       9596     9599       +3     
Impacted Files Coverage Δ
...src/main/java/org/batfish/datamodel/NamedPort.java 100.00% <100.00%> (ø)
...fish/grammar/flatjuniper/ConfigurationBuilder.java 74.36% <100.00%> (+0.02%) ⬆️
...tfish/representation/juniper/JunosApplication.java 99.46% <100.00%> (+0.01%) ⬆️
...sh/representation/juniper/JunosApplicationSet.java 93.22% <100.00%> (+0.23%) ⬆️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.62%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.56% <0.00%> (-0.16%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.70% <0.00%> (-0.09%) ⬇️

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@ratulm ratulm merged commit 0588387 into master Feb 4, 2022
@ratulm ratulm deleted the junos-app branch February 4, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more built-in Junos applications
3 participants