Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general: cleanup asn grammar #8011

Merged
merged 1 commit into from Feb 7, 2022
Merged

general: cleanup asn grammar #8011

merged 1 commit into from Feb 7, 2022

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Feb 6, 2022

Make sure ASNs are always using typed integers
Get rid of some int vs long cases
add deprecated int functions to problematic classes to catch future misuses

Likely fixes #8009

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #8011 (82f9eb0) into master (1254f99) will increase coverage by 0.01%.
The diff coverage is 46.15%.

@@             Coverage Diff              @@
##             master    #8011      +/-   ##
============================================
+ Coverage     74.31%   74.32%   +0.01%     
- Complexity    42886    42954      +68     
============================================
  Files          3349     3351       +2     
  Lines        168208   168452     +244     
  Branches      20157    20179      +22     
============================================
+ Hits         125001   125206     +205     
- Misses        33600    33619      +19     
- Partials       9607     9627      +20     
Impacted Files Coverage Δ
...fish/datamodel/routing_policy/expr/ExplicitAs.java 38.88% <0.00%> (-4.87%) ⬇️
...sh/grammar/cisco_asa/AsaControlPlaneExtractor.java 19.52% <0.00%> (ø)
...sh/grammar/arista/AristaControlPlaneExtractor.java 46.55% <50.00%> (ø)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 62.11% <50.00%> (ø)
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java 44.33% <50.00%> (ø)
...fish/grammar/flatjuniper/ConfigurationBuilder.java 74.45% <100.00%> (+0.11%) ⬆️
...java/org/batfish/vendor/a10/representation/Ha.java 88.88% <0.00%> (-3.42%) ⬇️
...model/routing_policy/communities/CommunitySet.java 93.84% <0.00%> (-1.54%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...sh/vendor/a10/representation/A10Configuration.java 91.97% <0.00%> (-1.02%) ⬇️
... and 19 more

Make sure ASNs are always using typed integers
Get rid of some int vs long cases
add deprecated int functions to problematic classes to catch future misuses

Likely fixes batfish#8009
Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@dhalperi dhalperi merged commit ffd8079 into batfish:master Feb 7, 2022
@dhalperi dhalperi deleted the bgp-asn branch February 7, 2022 05:51
arifogel added a commit to arifogel/batfish that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 Bytes ASN not supported in Route-map
3 participants