Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JunOS: clean-up prefix-list to IpSpace conversion #8060

Merged
merged 3 commits into from Feb 18, 2022

Conversation

dhalperi
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #8060 (4ba7198) into master (66fc72b) will decrease coverage by 0.01%.
The diff coverage is 70.83%.

@@             Coverage Diff              @@
##             master    #8060      +/-   ##
============================================
- Coverage     74.41%   74.39%   -0.02%     
+ Complexity    43085    43078       -7     
============================================
  Files          3361     3361              
  Lines        168738   168696      -42     
  Branches      20202    20199       -3     
============================================
- Hits         125567   125504      -63     
- Misses        33520    33536      +16     
- Partials       9651     9656       +5     
Impacted Files Coverage Δ
...fish/grammar/flatjuniper/ConfigurationBuilder.java 75.36% <0.00%> (+0.04%) ⬆️
...h/representation/juniper/JuniperConfiguration.java 89.29% <0.00%> (ø)
...entation/juniper/PsFromPrefixListFilterLonger.java 68.00% <60.00%> (+1.33%) ⬆️
...tation/juniper/PsFromPrefixListFilterOrLonger.java 68.00% <68.42%> (-8.00%) ⬇️
...sentation/juniper/FwFromDestinationPrefixList.java 71.42% <80.00%> (-5.85%) ⬇️
...ion/juniper/FwFromDestinationPrefixListExcept.java 71.42% <80.00%> (-5.85%) ⬇️
...tfish/representation/juniper/FwFromPrefixList.java 92.85% <80.00%> (+1.94%) ⬆️
...representation/juniper/FwFromSourcePrefixList.java 92.85% <80.00%> (+1.94%) ⬆️
...entation/juniper/FwFromSourcePrefixListExcept.java 92.85% <80.00%> (+1.94%) ⬆️
...org/batfish/representation/juniper/PrefixList.java 100.00% <100.00%> (+22.22%) ⬆️
... and 11 more

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 17 files reviewed, all discussions resolved (waiting on @arifogel and @ratulm)


projects/batfish/src/main/antlr4/org/batfish/grammar/flatjuniper/FlatJuniper_policy_options.g4, line 112 at r1 (raw file):

;

poplt_ip6

FYI this grammar rule never used.

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 17 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants