Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista EOS do not treat vxlan multicast-groups as VTEPs #8085

Merged
merged 1 commit into from Feb 26, 2022

Conversation

arifogel
Copy link
Member

- Fixes batfish#8061
- Multicast-groups are not supported for BUM traffic on EOS up to at least 4.23
  - They are only for BM traffic, and should not displace unicast VTEPs
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #8085 (435a6cb) into master (60c419a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8085      +/-   ##
============================================
- Coverage     74.42%   74.40%   -0.02%     
+ Complexity    43118    43104      -14     
============================================
  Files          3362     3362              
  Lines        168869   168865       -4     
  Branches      20218    20217       -1     
============================================
- Hits         125686   125650      -36     
- Misses        33527    33552      +25     
- Partials       9656     9663       +7     
Impacted Files Coverage Δ
...ish/representation/arista/AristaConfiguration.java 64.86% <ø> (-0.10%) ⬇️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-4.77%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 80.23% <0.00%> (-2.33%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...main/java/org/batfish/datamodel/acl/AclTracer.java 63.69% <0.00%> (-1.28%) ⬇️
...bddreachability/BDDReachabilityGraphOptimizer.java 82.82% <0.00%> (-1.02%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.86%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 48.00% <0.00%> (-0.45%) ⬇️
... and 3 more

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@arifogel arifogel merged commit 507e6f8 into batfish:master Feb 26, 2022
@arifogel arifogel deleted the ari-fix-8061 branch February 26, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARISTA: VXLAN multicast group misinterpreted as multicast flood group
3 participants