Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOS: extract 25gfull #8106

Merged
merged 1 commit into from Mar 2, 2022
Merged

EOS: extract 25gfull #8106

merged 1 commit into from Mar 2, 2022

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Mar 2, 2022

Fix #8103

@dhalperi dhalperi requested a review from arifogel March 2, 2022 18:33
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8106 (8ee98aa) into master (905d5e6) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff            @@
##             master    #8106   +/-   ##
=========================================
  Coverage     74.45%   74.45%           
  Complexity    43159    43159           
=========================================
  Files          3363     3363           
  Lines        169031   169039    +8     
  Branches      20239    20241    +2     
=========================================
+ Hits         125846   125853    +7     
+ Misses        33529    33525    -4     
- Partials       9656     9661    +5     
Impacted Files Coverage Δ
...sh/grammar/arista/AristaControlPlaneExtractor.java 46.58% <75.00%> (+0.02%) ⬆️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 48.00% <0.00%> (-0.45%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 86.08% <0.00%> (-0.25%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.53% <0.00%> (-0.16%) ⬇️
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 78.59% <0.00%> (+0.27%) ⬆️

@dhalperi dhalperi merged commit 81fb88e into batfish:master Mar 2, 2022
@dhalperi dhalperi deleted the 25gful branch March 2, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port speed 25gfull is not recognized
3 participants