Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: do not model nve1 as an interface #8107

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Mar 2, 2022

No description provided.

@dhalperi dhalperi requested a review from arifogel March 2, 2022 22:07
@batfish-bot
Copy link

This change is Reviewable

@dhalperi
Copy link
Member Author

dhalperi commented Mar 2, 2022

Fixes the proximal issue in #8102

@dhalperi dhalperi linked an issue Mar 2, 2022 that may be closed by this pull request
Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8107 (fb41abe) into master (81fb88e) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8107      +/-   ##
============================================
- Coverage     74.45%   74.27%   -0.19%     
+ Complexity    43163    43062     -101     
============================================
  Files          3363     3363              
  Lines        169039   169037       -2     
  Branches      20241    20240       -1     
============================================
- Hits         125859   125547     -312     
- Misses        33519    33842     +323     
+ Partials       9661     9648      -13     
Impacted Files Coverage Δ
...src/main/java/org/batfish/datamodel/Interface.java 86.22% <ø> (+0.23%) ⬆️
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 62.49% <ø> (ø)
...a/org/batfish/common/topology/broadcast/Edges.java 0.00% <0.00%> (-100.00%) ⬇️
...common/topology/broadcast/L3AdjacencyComputer.java 0.00% <0.00%> (-94.38%) ⬇️
...mmon/topology/broadcast/DeviceBroadcastDomain.java 0.00% <0.00%> (-92.86%) ⬇️
...mon/topology/broadcast/BroadcastL3Adjacencies.java 0.00% <0.00%> (-73.92%) ⬇️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...batfish/representation/aws/LoadBalancerTarget.java 54.16% <0.00%> (-4.17%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 55.95% <0.00%> (-3.58%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
... and 3 more

@dhalperi dhalperi merged commit 8854d40 into batfish:master Mar 2, 2022
@dhalperi dhalperi deleted the nve branch March 2, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False red flag for "Unable assign vlan for interface nve1"?
3 participants