Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper SRX parse and warn security policy then permit application-services #8127

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Mar 9, 2022

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #8127 (d4c5e7c) into master (f8044cc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8127      +/-   ##
============================================
- Coverage     74.48%   74.47%   -0.01%     
+ Complexity    43279    43277       -2     
============================================
  Files          3373     3373              
  Lines        169342   169344       +2     
  Branches      20269    20269              
============================================
- Hits         126128   126120       -8     
- Misses        33536    33542       +6     
- Partials       9678     9682       +4     
Impacted Files Coverage Δ
...fish/grammar/flatjuniper/ConfigurationBuilder.java 75.45% <100.00%> (+0.01%) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-4.77%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.42% <0.00%> (-0.31%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.68% <0.00%> (+0.15%) ⬆️

@arifogel arifogel merged commit dc7e6af into batfish:master Mar 9, 2022
@arifogel arifogel deleted the ari-srx-app-ser branch March 9, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Juniper SRX parse failure for security policy then permit application-services
3 participants