Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frr: Do not call addNeighbor on peer group neighbors #8157

Merged
merged 1 commit into from Mar 18, 2022

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Mar 17, 2022

Downstream code generates spurious warnings when addNeighbor is called for peerGroup neighbors.

@batfish-bot
Copy link

This change is Reviewable

@ratulm ratulm requested a review from dhalperi March 17, 2022 07:00
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #8157 (b33961c) into master (cd98766) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #8157      +/-   ##
============================================
- Coverage     74.49%   74.48%   -0.01%     
+ Complexity    43366    43363       -3     
============================================
  Files          3376     3376              
  Lines        169538   169538              
  Branches      20295    20295              
============================================
- Hits         126295   126283      -12     
- Misses        33556    33566      +10     
- Partials       9687     9689       +2     
Impacted Files Coverage Δ
...org/batfish/representation/frr/FrrConversions.java 88.53% <50.00%> (-0.24%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 80.23% <0.00%> (-2.33%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 48.00% <0.00%> (-0.45%) ⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.56% <0.00%> (-0.25%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 86.08% <0.00%> (-0.25%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.74% <0.00%> (-0.16%) ⬇️

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ratulm)

@ratulm ratulm merged commit 6c2db35 into master Mar 18, 2022
@ratulm ratulm deleted the frr-bgp-peer-group branch March 18, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants