-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAN: revamp application definitions #8178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @arifogel and @dhalperi)
projects/batfish/src/main/java/org/batfish/representation/palo_alto/application_definitions/ApplicationDefinition.java, line 37 at r1 (raw file):
} @Nullable
It's not 100% clear to me what some of these properties mean, but we can fill in details as we learn more.
These properties do seem relevant to building a correct hierarchy of apps and understanding interactions, so I went ahead and added them to this new model.
Code quote:
@Nullable
public String getParentApp() {
return _parentApp;
}
@Nullable
public UseApplications getUseApplications() {
return _useApplications;
}
@Nullable
public UseApplications getImplicitUseApplications() {
return _implicitUseApplications;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Codecov Report
@@ Coverage Diff @@
## master #8178 +/- ##
============================================
- Coverage 74.49% 74.49% -0.01%
- Complexity 43364 43392 +28
============================================
Files 3376 3381 +5
Lines 169538 169625 +87
Branches 20295 20301 +6
============================================
+ Hits 126294 126358 +64
- Misses 33556 33573 +17
- Partials 9688 9694 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Add new VS datamodel representation for Palo Alto applications.
Will separately: