Xr: Interface reference tracking

[ratulm]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #8194 (b5a2239) into master (24747ce) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b5a2239 differs from pull request most recent head de6418e. Consider uploading reports for the commit de6418e to get more accurate results

@@             Coverage Diff              @@
##             master    #8194      +/-   ##
============================================
- Coverage     74.54%   74.53%   -0.02%     
+ Complexity    43453    43444       -9     
============================================
  Files          3386     3386              
  Lines        169029   169032       +3     
  Branches      20155    20155              
============================================
- Hits         126000   125981      -19     
- Misses        33493    33510      +17     
- Partials       9536     9541       +5     

Impacted Files	Coverage Δ
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java	44.34% <100.00%> (+0.03%)	⬆️
.../datamodel/routing_policy/statement/Statement.java	72.72% <0.00%> (-9.10%)	⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java	54.76% <0.00%> (-5.96%)	⬇️
...col/src/main/java/org/batfish/role/InferRoles.java	91.36% <0.00%> (-1.37%)	⬇️
...main/java/org/batfish/datamodel/acl/AclTracer.java	63.69% <0.00%> (-1.28%)	⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java	70.93% <0.00%> (-0.59%)	⬇️
...batfish/src/main/java/org/batfish/main/Driver.java	49.18% <0.00%> (-0.55%)	⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java	75.50% <0.00%> (-0.47%)	⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	87.56% <0.00%> (-0.25%)	⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java	86.08% <0.00%> (-0.25%)	⬇️
... and 1 more

[arifogel]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi and @ratulm)

---

projects/batfish/src/test/java/org/batfish/grammar/cisco_xr/XrGrammarTest.java, line 434 at r1 (raw file):

    assertThat(ccae, hasReferencedStructure(filename, INTERFACE, "Bundle-Ether1", HSRP_INTERFACE));
    assertThat(
        ccae, hasUndefinedReference(filename, INTERFACE, "Bundle-Ether2", ROUTER_STATIC_ROUTE));

Please add a test that Bundle-Ether1 is defined.

[ratulm]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

[arifogel]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)