Jackson: upgrade for CVE-2020-36518

[dhalperi]

Includes fixups:

• new builder pattern
• Jackson now correctly implements Include.NON_EMPTY for JsonValue,
  so things like IntegerSpace are not serialized instead of "".
  Fix a few deserializers as a result.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #8201 (ccd7f92) into master (baf8916) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8201      +/-   ##
============================================
- Coverage     74.48%   74.47%   -0.01%     
- Complexity    43494    43496       +2     
============================================
  Files          3387     3387              
  Lines        168687   168718      +31     
  Branches      20168    20178      +10     
============================================
+ Hits         125653   125660       +7     
- Misses        33490    33510      +20     
- Partials       9544     9548       +4     

Impacted Files	Coverage Δ
...a/org/batfish/common/util/BatfishObjectMapper.java	72.72% <100.00%> (-1.19%)	⬇️
...src/main/java/org/batfish/datamodel/Interface.java	86.61% <100.00%> (ø)
...tamodel/routing_policy/expr/ExplicitPrefixSet.java	60.00% <100.00%> (-1.54%)	⬇️
...atfish/datamodel/vendor_family/cumulus/Bridge.java	88.88% <100.00%> (+3.17%)	⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java	54.76% <0.00%> (-4.77%)	⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java	83.82% <0.00%> (-2.95%)	⬇️
...col/src/main/java/org/batfish/role/InferRoles.java	91.36% <0.00%> (-1.37%)	⬇️
...main/java/org/batfish/datamodel/acl/AclTracer.java	63.69% <0.00%> (-1.28%)	⬇️
...bddreachability/BDDReachabilityGraphOptimizer.java	82.82% <0.00%> (-1.02%)	⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java	70.93% <0.00%> (-0.59%)	⬇️
... and 8 more

[dhalperi]

Reviewable status: 0 of 18 files reviewed, all discussions resolved (waiting on @arifogel)

---

projects/coordinator/BUILD, line 15 at r1 (raw file):

    runtime_deps = [
        "//projects/question",
        "@maven//:javax_activation_activation",

FYI this is not needed because it's already a direct dependency of existing libs.

[arifogel]

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dhalperi)

---

projects/pom.xml, line 74 at r1 (raw file):

        <jackson.version>2.13.2.20220328</jackson.version>
        <jakarta-activation.version>1.2.2</jakarta-activation.version>
        <javax-activation.version>1.1</javax-activation.version>

Do we need explicit javax-activation version or dep in maven anymore?

---

projects/batfish-common-protocol/src/main/java/org/batfish/common/util/BatfishObjectMapper.java, line 166 at r1 (raw file):

  }

  /** Configures all the default options for a Batfish {@link ObjectMapper}. */

Is javadoc still accurate?

[dhalperi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

---

projects/batfish-common-protocol/src/main/java/org/batfish/common/util/BatfishObjectMapper.java, line 166 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

Is javadoc still accurate?

I think it's fine. Did you want a specific change?

[arifogel]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

---

projects/batfish-common-protocol/src/main/java/org/batfish/common/util/BatfishObjectMapper.java, line 166 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

I think it's fine. Did you want a specific change?

Just making sure ObjectMapper is still accurate. I guess so, given the lack of other changes.

[dhalperi]

Reviewed 15 of 18 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

[arifogel]

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)