Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic: Parse and convert snmp community information #8214

Merged
merged 3 commits into from Apr 4, 2022
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Apr 2, 2022

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@ratulm ratulm requested a review from arifogel April 2, 2022 20:52
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #8214 (cb3d161) into master (ffd3daa) will decrease coverage by 0.00%.
The diff coverage is 90.80%.

@@             Coverage Diff              @@
##             master    #8214      +/-   ##
============================================
- Coverage     74.51%   74.50%   -0.01%     
- Complexity    43543    43559      +16     
============================================
  Files          3392     3393       +1     
  Lines        168806   168880      +74     
  Branches      20186    20194       +8     
============================================
+ Hits         125785   125830      +45     
- Misses        33479    33496      +17     
- Partials       9542     9554      +12     
Impacted Files Coverage Δ
...ndor/sonic/grammar/SonicControlPlaneExtractor.java 89.21% <54.54%> (-4.20%) ⬇️
...endor/sonic/representation/SonicConfiguration.java 58.92% <87.50%> (+1.78%) ⬆️
.../vendor/sonic/representation/SonicConversions.java 92.53% <95.34%> (-0.17%) ⬇️
.../batfish/vendor/sonic/representation/AclTable.java 100.00% <100.00%> (ø)
...g/batfish/vendor/sonic/representation/SnmpYml.java 100.00% <100.00%> (ø)
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-5.96%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.50% <0.00%> (-0.47%) ⬇️
... and 4 more

@ratulm ratulm changed the title Sonic: Parse snmp community information Sonic: Parse and convert snmp community information Apr 3, 2022
@ratulm ratulm requested a review from dhalperi April 3, 2022 03:09
Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 9 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @ratulm)


projects/batfish/pom.xml, line 367 at r2 (raw file):

      <groupId>com.fasterxml.jackson.dataformat</groupId>
      <artifactId>jackson-dataformat-yaml</artifactId>
      <version>2.13.0</version>

no versions outside of main pom.xml.

Code quote:

<version>2.13.0</version>

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@ratulm ratulm merged commit d01734a into master Apr 4, 2022
@ratulm ratulm deleted the sonic-snmp branch April 4, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants