Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juniper use lexer mode to handle dotted ASN in more places #8227

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Apr 7, 2022

Use mode after:

  • autonomous-system
  • local-as
  • peer-as

Use mode after:
- autonomous-system
- local-as
- peer-as
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #8227 (e23d7fa) into master (ec69c7f) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8227      +/-   ##
============================================
- Coverage     74.55%   74.54%   -0.01%     
- Complexity    43658    43659       +1     
============================================
  Files          3400     3401       +1     
  Lines        169262   169295      +33     
  Branches      20224    20224              
============================================
+ Hits         126188   126206      +18     
- Misses        33512    33521       +9     
- Partials       9562     9568       +6     
Impacted Files Coverage Δ
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...bddreachability/BDDReachabilityGraphOptimizer.java 82.82% <0.00%> (-1.02%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.62%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (-0.16%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.67% <0.00%> (-0.09%) ⬇️
...l/src/main/java/org/batfish/datamodel/UdpPort.java 93.93% <0.00%> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 84.83% <0.00%> (+0.14%) ⬆️

@arifogel arifogel merged commit 8575686 into batfish:master Apr 7, 2022
@arifogel arifogel deleted the ari-junos-bgp-asn-mode branch April 7, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants