Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: support deleting individual prefix-list seqs #8259

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Apr 23, 2022

Also rewrite grammar a little bit

commit-id:f8a1c497

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Also rewrite grammar a little bit

commit-id:f8a1c497
@dhalperi dhalperi force-pushed the pr/dhalperi/prefix-list/f8a1c497 branch from 592ce03 to ee711f0 Compare April 23, 2022 22:18
Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #8259 (ee711f0) into master (f71a9f5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8259      +/-   ##
============================================
- Coverage     74.58%   74.57%   -0.01%     
- Complexity    43734    43735       +1     
============================================
  Files          3405     3405              
  Lines        169398   169411      +13     
  Branches      20229    20232       +3     
============================================
- Hits         126341   126337       -4     
- Misses        33490    33503      +13     
- Partials       9567     9571       +4     
Impacted Files Coverage Δ
...sh/grammar/arista/AristaControlPlaneExtractor.java 47.38% <100.00%> (+0.15%) ⬆️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...main/java/org/batfish/datamodel/acl/AclTracer.java 63.69% <0.00%> (-1.28%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.86%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (-0.16%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.67% <0.00%> (-0.09%) ⬇️

@dhalperi dhalperi merged commit e3aad85 into master Apr 23, 2022
@dhalperi dhalperi deleted the pr/dhalperi/prefix-list/f8a1c497 branch April 23, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants