Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: implement neighbor deletion and add warnings #8260

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

dhalperi
Copy link
Member

  1. Implement delete neighbor for IPv4 neighbors.
  2. Add warnings around improper deletions.

1. Implement delete neighbor for IPv4 neighbors.
2. Add warnings around improper deletions.

commit-id:fa69913e
@batfish-bot
Copy link

This change is Reviewable

@dhalperi dhalperi requested a review from ratulm April 23, 2022 23:50
Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #8260 (ea2f882) into master (1ce37e4) will decrease coverage by 0.00%.
The diff coverage is 55.26%.

@@             Coverage Diff              @@
##             master    #8260      +/-   ##
============================================
- Coverage     74.57%   74.56%   -0.01%     
- Complexity    43735    43743       +8     
============================================
  Files          3405     3406       +1     
  Lines        169415   169451      +36     
  Branches      20233    20240       +7     
============================================
+ Hits         126340   126357      +17     
- Misses        33502    33522      +20     
+ Partials       9573     9572       -1     
Impacted Files Coverage Δ
...representation/arista/eos/AristaBgpV6Neighbor.java 0.00% <0.00%> (ø)
...sh/grammar/arista/AristaControlPlaneExtractor.java 47.57% <77.77%> (+0.16%) ⬆️
...bddreachability/BDDReachabilityGraphOptimizer.java 82.82% <0.00%> (-1.02%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.62%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 49.18% <0.00%> (-0.55%) ⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.56% <0.00%> (-0.25%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.71% <0.00%> (-0.15%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (+0.31%) ⬆️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 71.51% <0.00%> (+0.58%) ⬆️
... and 2 more

@dhalperi dhalperi merged commit e837e59 into master Apr 24, 2022
@dhalperi dhalperi deleted the pr/dhalperi/arista-no-bgp/fa69913e branch April 24, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants