Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXOS: Allow ICMP ACL lines without l4 options #8267

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Apr 25, 2022

Fixes #8264

@ratulm ratulm requested a review from dhalperi April 25, 2022 21:56
@batfish-bot
Copy link

This change is Reviewable

@ratulm ratulm requested a review from arifogel April 25, 2022 21:56
Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #8267 (1983ca6) into master (4aebc34) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8267      +/-   ##
============================================
- Coverage     74.58%   74.57%   -0.02%     
+ Complexity    43771    43760      -11     
============================================
  Files          3407     3407              
  Lines        169498   169498              
  Branches      20247    20247              
============================================
- Hits         126426   126398      -28     
- Misses        33503    33524      +21     
- Partials       9569     9576       +7     
Impacted Files Coverage Δ
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-5.96%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.86%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 49.18% <0.00%> (-0.55%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.50% <0.00%> (-0.47%) ⬇️
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 89.08% <0.00%> (-0.36%) ⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.56% <0.00%> (-0.25%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.67% <0.00%> (-0.09%) ⬇️

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cisco NX-OS] ICMP is allowed in the ACL but is denied.
3 participants