Cisco NX-OS support no aggregate-address

[arifogel]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #8280 (8060b64) into master (eaf4a0e) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff            @@
##             master    #8280   +/-   ##
=========================================
  Coverage     74.58%   74.58%           
- Complexity    43773    43804   +31     
=========================================
  Files          3407     3407           
  Lines        169510   169609   +99     
  Branches      20248    20273   +25     
=========================================
+ Hits         126435   126509   +74     
- Misses        33505    33513    +8     
- Partials       9570     9587   +17     

Impacted Files	Coverage Δ
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java	78.81% <89.65%> (+0.21%)	⬆️
...sco_nxos/BgpVrfIpv4AddressFamilyConfiguration.java	100.00% <100.00%> (ø)
...sco_nxos/BgpVrfIpv6AddressFamilyConfiguration.java	100.00% <100.00%> (+18.75%)	⬆️
.../datamodel/routing_policy/statement/Statement.java	72.72% <0.00%> (-9.10%)	⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java	54.76% <0.00%> (-4.77%)	⬇️
...batfish/representation/aws/LoadBalancerTarget.java	54.16% <0.00%> (-4.17%)	⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java	83.82% <0.00%> (-2.95%)	⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java	70.93% <0.00%> (-0.59%)	⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java	75.50% <0.00%> (-0.47%)	⬇️
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java	89.08% <0.00%> (-0.36%)	⬇️
... and 7 more

[dhalperi]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)

[dhalperi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel, @corinaminer, and @sfraint)

---

projects/batfish/src/main/java/org/batfish/grammar/cisco_nxos/CiscoNxosControlPlaneExtractor.java line 3658 at r1 (raw file):

    boolean removed = afConfig.removeAggregateNetwork(prefix);
    if (!removed) {
      warn(ctx, String.format("Removing non-existent aggregate network: %s", prefix));

add vrf?

[arifogel]

Reviewable status: 3 of 6 files reviewed, all discussions resolved (waiting on @corinaminer, @dhalperi, and @sfraint)

---

projects/batfish/src/main/java/org/batfish/grammar/cisco_nxos/CiscoNxosControlPlaneExtractor.java line 3658 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

add vrf?

done

[dhalperi]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)