Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: fix tracking of ip pim ssm range #8293

Merged
merged 1 commit into from
May 3, 2022
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented May 3, 2022

  1. IOS does not allow prefix, just std ACL
  2. Rewrite grammar slightly to be LL1.

Fix #8287

commit-id:6145b413

Issue references:

@batfish-bot
Copy link

This change is Reviewable

1. IOS does not allow prefix, just std ACL
2. Rewrite grammar slightly to be LL1.

Fix #8287

commit-id:6145b413
@dhalperi dhalperi force-pushed the pr/dhalperi/ip-pim/6145b413 branch from 822a7ed to c0c4d3a Compare May 3, 2022 17:40
@dhalperi dhalperi requested review from arifogel and sfraint May 3, 2022 17:40
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #8293 (c0c4d3a) into master (85f78d9) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #8293      +/-   ##
============================================
- Coverage     74.59%   74.58%   -0.01%     
+ Complexity    43832    43824       -8     
============================================
  Files          3407     3407              
  Lines        169702   169703       +1     
  Branches      20294    20294              
============================================
- Hits         126581   126572       -9     
- Misses        33528    33535       +7     
- Partials       9593     9596       +3     
Impacted Files Coverage Δ
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 62.75% <80.00%> (ø)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <100.00%> (ø)
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...bddreachability/BDDReachabilityGraphOptimizer.java 82.82% <0.00%> (-1.02%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 49.18% <0.00%> (-0.55%) ⬇️
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 89.08% <0.00%> (-0.36%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (-0.16%) ⬇️

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sfraint)

@dhalperi dhalperi merged commit f90c8a9 into master May 3, 2022
@dhalperi dhalperi deleted the pr/dhalperi/ip-pim/6145b413 branch May 3, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACL incorrectly flagged as unused in Cisco IOSXE > ip pim
3 participants