Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRR: Inherit routemaps from peer groups #8301

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented May 9, 2022

No description provided.

@ratulm ratulm requested review from dhalperi and arifogel May 9, 2022 06:03
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #8301 (e72e1c1) into master (d108cc4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8301      +/-   ##
============================================
- Coverage     74.60%   74.59%   -0.02%     
+ Complexity    43870    43867       -3     
============================================
  Files          3410     3410              
  Lines        169815   169819       +4     
  Branches      20309    20311       +2     
============================================
- Hits         126686   126672      -14     
- Misses        33527    33543      +16     
- Partials       9602     9604       +2     
Impacted Files Coverage Δ
...ation/frr/BgpNeighborIpv4UnicastAddressFamily.java 100.00% <100.00%> (ø)
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...fish/bddreachability/BDDLoopDetectionAnalysis.java 83.82% <0.00%> (-2.95%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.86%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 49.18% <0.00%> (-0.55%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.73% <0.00%> (-0.15%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.67% <0.00%> (-0.09%) ⬇️

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@ratulm ratulm merged commit 8137b75 into master May 9, 2022
@ratulm ratulm deleted the frr-inherit-routemap branch May 9, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants