IspModelingUtils: add explanations when ISP-side generation fails #8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Help users debug ISP configuration, and also document current gaps, which we are in the process of fixing. commit-id:ef80c576
dhalperi
force-pushed
the
pr/dhalperi/isp-debug/ef80c576
branch
from
58af229
to
7b67951
Compare
Codecov Report
@@ Coverage Diff @@
## master #8303 +/- ##
=========================================
Coverage 74.59% 74.60%
- Complexity 43871 43877 +6
=========================================
Files 3410 3410
Lines 169824 169835 +11
Branches 20312 20313 +1
=========================================
+ Hits 126681 126704 +23
+ Misses 33538 33528 -10
+ Partials 9605 9603 -2
|
ratulm
reviewed
May 11, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help users debug ISP configuration, and also document current gaps, which
we are in the process of fixing.