IspModeling: enable not-configured local IP for BgpPeerInfo #8307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During ISP modeling, we need to generate correct ISP-side BGP configuration. This requires, in particular, specifying the neighbor on that side -- aka, the local IP on the node in the snapshot. This is usually configured via an explicit update source or local address command, but may not always be. To support ISP modeling for these cases, we: 1. provide a way to force local IP in the BgpPeerInfo 2. improve default local IP inference to include local connected routes (same VRF) for eBGP singlehop sessions. commit-id:bb5c7cb7
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #8307 +/- ##
=========================================
Coverage 74.62% 74.62%
Complexity 43896 43896
=========================================
Files 3410 3410
Lines 169863 169863
Branches 20310 20310
=========================================
Hits 126753 126753
Misses 33516 33516
Partials 9594 9594 |
ratulm
reviewed
May 13, 2022
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During ISP modeling, we need to generate correct ISP-side BGP configuration.
This requires, in particular, specifying the neighbor on that side -- aka,
the local IP on the node in the snapshot. This is usually configured via
an explicit update source or local address command, but may not always be.
To support ISP modeling for these cases, we:
connected routes (same VRF) for eBGP singlehop sessions.