Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arista: handle undefined references in dynamic source nat #8310

Merged
merged 1 commit into from
May 16, 2022

Conversation

dhalperi
Copy link
Member

Fix a crash.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)


projects/batfish/src/main/java/org/batfish/representation/arista/AristaConfiguration.java line 1378 at r1 (raw file):

      if (!_extendedAccessLists.containsKey(nat.getNatAclName())) {
        // https://www.arista.com/en/um-eos/eos-data-plane-security#xx1143262
        // Commands referencing nonexistent ACLs are accepted by the CLI but not installed in

FYI copied from a few lines up (static nat)

@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #8310 (f3f2878) into master (c674c38) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #8310      +/-   ##
============================================
- Coverage     74.61%   74.60%   -0.01%     
+ Complexity    43897    43895       -2     
============================================
  Files          3410     3410              
  Lines        169889   169895       +6     
  Branches      20310    20311       +1     
============================================
- Hits         126765   126757       -8     
- Misses        33531    33544      +13     
- Partials       9593     9594       +1     
Impacted Files Coverage Δ
...ish/representation/arista/AristaConfiguration.java 64.91% <100.00%> (+0.12%) ⬆️
.../representation/arista/AristaDynamicSourceNat.java 86.66% <100.00%> (+0.95%) ⬆️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 85.47% <0.00%> (-0.86%) ⬇️
...batfish/src/main/java/org/batfish/main/Driver.java 49.18% <0.00%> (-0.55%) ⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.56% <0.00%> (-0.25%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (-0.16%) ⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.67% <0.00%> (-0.09%) ⬇️

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@dhalperi dhalperi merged commit dfa1cf3 into batfish:master May 16, 2022
@dhalperi dhalperi deleted the arista-dynamic-nat-acl branch May 16, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants