FRR: allow neighbors to be defined out of order #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ratulm
reviewed
May 19, 2022
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
It seems that FRR does not apply address-family configuration until after all top-level neighbors are defined, even if those declarations come after the address-family section. Support this, and also no longer warn at parsing time for such cases. commit-id:fac91090
dhalperi
force-pushed
the
pr/dhalperi/frr-inheritance/fac91090
branch
from
ef4f85c
to
da25b5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #8320 +/- ##
=========================================
Coverage 74.62% 74.62%
Complexity 43908 43908
=========================================
Files 3410 3410
Lines 169948 169948
Branches 20312 20312
=========================================
Hits 126819 126819
Misses 33532 33532
Partials 9597 9597 |
ratulm
reviewed
May 19, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that FRR does not apply address-family configuration until after all
top-level neighbors are defined, even if those declarations come after the
address-family section.
Support this, and also no longer warn at parsing time for such cases.
commit-id:fac91090