Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN: fix NAT addresses reference tracking #8367

Merged
merged 3 commits into from
Jun 13, 2022
Merged

PAN: fix NAT addresses reference tracking #8367

merged 3 commits into from
Jun 13, 2022

Conversation

sfraint
Copy link
Member

@sfraint sfraint commented Jun 13, 2022

Fix address references from NAT rules.

Also add a broader test for references from NAT rules.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #8367 (72c451f) into master (955ad65) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8367      +/-   ##
============================================
- Coverage     74.73%   74.72%   -0.02%     
+ Complexity    44023    44017       -6     
============================================
  Files          3419     3419              
  Lines        170084   170080       -4     
  Branches      20290    20289       -1     
============================================
- Hits         127108   127088      -20     
- Misses        33376    33390      +14     
- Partials       9600     9602       +2     
Impacted Files Coverage Δ
...epresentation/palo_alto/PaloAltoConfiguration.java 90.46% <ø> (+0.30%) ⬆️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 55.95% <0.00%> (-3.58%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 86.00% <0.00%> (-0.60%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 76.02% <0.00%> (-0.37%) ⬇️
...rg/batfish/dataplane/ibdp/EigrpRoutingProcess.java 89.08% <0.00%> (-0.36%) ⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 87.56% <0.00%> (-0.25%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.78% <0.00%> (-0.15%) ⬇️
... and 4 more

@sfraint sfraint merged commit a0d642b into master Jun 13, 2022
@sfraint sfraint deleted the pan-mark-nat-refs branch June 13, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants