Juniper add-path parsing, extraction, and reference tracking #8369
Conversation
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #8369 +/- ##
============================================
- Coverage 74.74% 74.73% -0.01%
- Complexity 44028 44053 +25
============================================
Files 3419 3422 +3
Lines 170080 170136 +56
Branches 20289 20291 +2
============================================
+ Hits 127119 127159 +40
- Misses 33367 33381 +14
- Partials 9594 9596 +2
|
There was a problem hiding this comment.
Reviewed 8 of 10 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @arifogel)
projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java line 7140 at r2 (raw file):
@Override public void exitBfiuas_prefix_policy(Bfiuas_prefix_policyContext ctx) { todo(ctx);
Seems redundant to warn here since we already warn on every add-path line.
projects/batfish/src/main/java/org/batfish/representation/juniper/BgpGroup.java line 62 at r2 (raw file):
_parent.cascadeInheritance(); if (_addPath == null) { _addPath = _parent._addPath;
Do individual properties cascade? E.g. if the parent sets add-path receive and the group has add-path send properties, does the group use the parent's receive setting?
projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java line 1256 at r2 (raw file):
BgpGroup n3 = ri.getIpBgpGroups().get(Prefix.strict("10.0.0.3/32")); assertTrue(master.getAddPath().getReceive());
Please test that receive is false for some other add-path object.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @corinaminer)
projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java line 7140 at r2 (raw file):
Previously, corinaminer (Corina Miner) wrote…
Seems redundant to warn here since we already warn on every
add-pathline.
Ah yeah started being specific but switched to general and missed this.
Fixed.
projects/batfish/src/main/java/org/batfish/representation/juniper/BgpGroup.java line 62 at r2 (raw file):
Previously, corinaminer (Corina Miner) wrote…
Do individual properties cascade? E.g. if the parent sets add-path receive and the group has add-path send properties, does the group use the parent's receive setting?
The entire add-path hierarchy is the finest level of inheritance here.
If you have any add-path settings at all at a level, you don't inherit from coarser level.
This also means that each add-path hierarchy must be valid by itself, since there are no merged sub-properties.
Tested on device and in wireshark.
projects/batfish/src/test/java/org/batfish/grammar/flatjuniper/FlatJuniperGrammarTest.java line 1256 at r2 (raw file):
Previously, corinaminer (Corina Miner) wrote…
Please test that receive is false for some other add-path object.
done
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @arifogel)
projects/batfish/src/main/java/org/batfish/representation/juniper/BgpGroup.java line 62 at r2 (raw file):
Previously, arifogel (Ari Fogel) wrote…
The entire add-path hierarchy is the finest level of inheritance here.
If you have any add-path settings at all at a level, you don't inherit from coarser level.
This also means that each add-path hierarchy must be valid by itself, since there are no merged sub-properties.
Tested on device and in wireshark.
sweet, thanks
No description provided.