Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use batfish z3 with latest patch addressing #485 #853

Merged
merged 3 commits into from
Jan 15, 2018
Merged

use batfish z3 with latest patch addressing #485 #853

merged 3 commits into from
Jan 15, 2018

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Jan 15, 2018 •
edited by dhalperi

This change is Reviewable

@dhalperi
Copy link
Member

Reviewed 5 of 6 files at r1.
Review status: 4 of 5 files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):
Please update all four Z3 install scripts.

Comments from Reviewable

@dhalperi
Copy link
Member

Reviewed 1 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@arifogel
Copy link
Member Author

Fixes #485

@arifogel
Copy link
Member Author

Review status: 5 of 8 files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):

Previously, dhalperi (Dan Halperin) wrote…

Please update all four Z3 install scripts.

Done

Comments from Reviewable

@dhalperi
Copy link
Member

:lgtm: as long as scripts have been tested and binaries are present.

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@arifogel arifogel merged commit 61b3aef into master Jan 15, 2018
@arifogel arifogel deleted the ari-use-batfish-z3 branch January 15, 2018 23:21
@arifogel arifogel mentioned this pull request Jan 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalperi dhalperi Awaiting requested review from dhalperi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arifogel @dhalperi