Cisco IOS enable autostate for extended VLANs

[rynogawa]

#8569
PR for the above issues.

[batfish-bot]

This change is 

[arifogel]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rynogawa)

a discussion (no related file):
First of all thanks for your contribution!

I did some research on this issue. It looks like the non-autostate behavior for extended VLANs was added a long time ago for a nexus issue. At the time, both nexus and IOS used the same data model in Batfish, so the changes incorrectly applied to both vendors.

In the PR where this happened, this nexus doc is referenced: http://www.cisco.com/c/en/us/td/docs/switches/datacenter/nexus5000/sw/configuration/guide/cli/CLIConfigurationGuide/VLANs.html

I was unable to find any IOS documentation stating that extended vlans are always on as in nexus. This combined with your investigation in your linked issue suggest that IOS uses autostate for extended vlans as well as regular vlans by default.

IOS still has a separation between regular and extended VLANs, but that is out of scope for this PR; the only thing I'd request from you in this PR is that you add some clarifying documentation to your changes. I've provided suggested text in separate comments.

---

---

projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConfiguration.java line 315 at r1 (raw file):

  public static final String RESOLUTION_POLICY_NAME = "~RESOLUTION_POLICY~";

  private static final int VLAN_NORMAL_MAX_CISCO = 4096;

Please add the following javadoc comment above this line:

/** Maximum VLAN number for which autostate is applied by default on IOS */

---

projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConfiguration.java line 317 at r1 (raw file):

  private static final int VLAN_NORMAL_MAX_CISCO = 4096;

  private static final int VLAN_NORMAL_MIN_CISCO = 2;

Please add following javadoc comment above this line:

/** Minimum VLAN number for which autostate is applied by default on IOS */

[codecov]

Codecov Report

Merging #8596 (72f127c) into master (9e8679e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8596   +/-   ##
=======================================
  Coverage   71.29%   71.29%           
=======================================
  Files        3276     3276           
  Lines      169105   169137   +32     
  Branches    19607    19616    +9     
=======================================
+ Hits       120565   120590   +25     
- Misses      39274    39276    +2     
- Partials     9266     9271    +5     

Impacted Files	Coverage Δ
...tfish/representation/cisco/CiscoConfiguration.java	81.38% <ø> (ø)
...fish/bddreachability/BDDLoopDetectionAnalysis.java	76.81% <0.00%> (-13.05%)	⬇️
...ish/datamodel/bgp/community/ExtendedCommunity.java	82.22% <0.00%> (-0.85%)	⬇️
...col/src/main/java/org/batfish/role/InferRoles.java	73.63% <0.00%> (-0.46%)	⬇️
.../batfish/representation/frr/RouteMapConvertor.java	96.06% <0.00%> (-0.20%)	⬇️
..._policy/communities/OpaqueExtendedCommunities.java	100.00% <0.00%> (+46.66%)	⬆️

[arifogel]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rynogawa)

[rynogawa]

@arifogel
Thank you for your quick and polite response.
I have responded to your instructions.