Cisco OSPF reference bandwidth

[dhalperi]

Draft PR to set up larger work on #873

---

This change is 

[arifogel]

Mostly good. Seems like a prime candidate for junit tests.

---

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[dhalperi]

Review status: 6 of 19 files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/representation/cisco/OspfProcess.java, line 87 at r2 (raw file):

      case ARISTA: // EOS manual, Chapter 27, "auto-cost reference-bandwidth (OSPFv2)"
        return DEFAULT_REFERENCE_BANDWIDTH_10_MBPS;

@arifogel which other vendors use the Cisco parser?

Before the recent revision, the code would have crashed on Arista devices (since the default throws), but it was not caught by any existing test.

Should I make the default just use IOS default?

---

Comments from Reviewable

[arifogel]

---

Reviewed 12 of 13 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/representation/cisco/OspfProcess.java, line 87 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

@arifogel which other vendors use the Cisco parser?

Before the recent revision, the code would have crashed on Arista devices (since the default throws), but it was not caught by any existing test.

Should I make the default just use IOS default?

I don't remember offhand which other vendors use that parse, but it's easy enough to check the switch case in ParseVendorConfigurationJob.
I don't think it's a good idea to have a default. I'd rather it throw by default.

---

Comments from Reviewable

[dhalperi]

Review status: 19 of 20 files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/representation/cisco/OspfProcess.java, line 87 at r2 (raw file):

Previously, arifogel (Ari Fogel) wrote…

I don't remember offhand which other vendors use that parse, but it's easy enough to check the switch case in ParseVendorConfigurationJob.
I don't think it's a good idea to have a default. I'd rather it throw by default.

Done.

---

Comments from Reviewable

[dhalperi]

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable