Juniper ospf cost

[dhalperi]

Review after #897.

For #873.

---

This change is 

[arifogel]

modulo question about enterOa_area_range

---

Reviewed 7 of 7 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java, line 1774 at r1 (raw file):

    if (ctx.IP_PREFIX() != null) {
      /* TODO: handle ipv6 */
      Prefix range = Prefix.parse(ctx.IP_PREFIX().getText());

It doesn't look like the data model is modified at this step, yet I feel like it should be. Doesn't something happen if you get this far?

---

Comments from Reviewable

[dhalperi]

Review status: 4 of 8 files reviewed at latest revision, 1 unresolved discussion.

---

projects/batfish/src/main/java/org/batfish/grammar/flatjuniper/ConfigurationBuilder.java, line 1774 at r1 (raw file):

Previously, arifogel (Ari Fogel) wrote…

It doesn't look like the data model is modified at this step, yet I feel like it should be. Doesn't something happen if you get this far?

Swapped to only create the configuration on exit, taking into account all parameters. Was also much cleaner to unify multiple optional configurations.

PTAL.

---

Comments from Reviewable

[arifogel]

---

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[dhalperi]

(Please squash my PRs unless otherwise specified -- or let me merge? This one dropped a bunch of crap commits into master.)