Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonPathQuestionPlugin: efficiency/memory win #945

Merged
merged 1 commit into from
Feb 15, 2018
Merged

JsonPathQuestionPlugin: efficiency/memory win #945

merged 1 commit into from
Feb 15, 2018

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Feb 15, 2018

Stop prettyifying json, since no user will see it.


This change is Reviewable

Stop prettyifying json, since no user will see it.
@dhalperi dhalperi requested a review from ratulm February 15, 2018 01:46
@dhalperi
Copy link
Member Author

(I haven't run the tests, so make sure to not accidentally admin-merge it ;)

@ratulm
Copy link
Member

ratulm commented Feb 15, 2018

:lgtm:


Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ratulm
Copy link
Member

ratulm commented Feb 15, 2018

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ratulm ratulm merged commit c645f2d into master Feb 15, 2018
@ratulm ratulm deleted the jsonpath branch February 15, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants