Unique asn

[ratulm]

A question to check if routers are using unique BGP ASNs.

---

This change is 

[dhalperi]

Reviewed 2 of 3 files at r1.
Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 24 at r1 (raw file):

@AutoService(Plugin.class)
public class UniqueBgpAsnQuestionPlugin extends QuestionPlugin {

Is it worth making this return all devices associated with an ASN, and having a flag to return only ones used by multiple nodes?

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 24 at r1 (raw file):

@AutoService(Plugin.class)
public class UniqueBgpAsnQuestionPlugin extends QuestionPlugin {

UniqueBgpAsn does not seem to describe what it does. ReusedBgpAsn? (that's crap, too.)

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 44 at r1 (raw file):

Bgp

BGP, when printing in a string?

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 109 at r1 (raw file):

bf_answer("UniqueBgpAsns", nodeRegex='as2.*')

what is this?

---

Comments from Reviewable

[dhalperi]

Reviewed 1 of 3 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 71 at r1 (raw file):

      Map<String, Configuration> configurations = _batfish.loadConfigurations();
      Set<String> nodes = question.getNodeRegex().getMatchingNodes(configurations);
      SortedMap<Integer, SortedSet<String>> asns = new TreeMap<>();

Will TreeMultimap simplify this for you? https://google.github.io/guava/releases/22.0/api/docs/com/google/common/collect/TreeMultimap.html

Note it does assume both keys and values are comparable so will give you the property you need.

---

Comments from Reviewable

[ratulm]

Review status: 0 of 6 files reviewed at latest revision, 5 unresolved discussions.

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 24 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

UniqueBgpAsn does not seem to describe what it does. ReusedBgpAsn? (that's crap, too.)

moot now, with the name change

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 24 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

Is it worth making this return all devices associated with an ASN, and having a flag to return only ones used by multiple nodes?

added a mincount parameter

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 44 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

Bgp

BGP, when printing in a string?

Done.

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 71 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

Will TreeMultimap simplify this for you? https://google.github.io/guava/releases/22.0/api/docs/com/google/common/collect/TreeMultimap.html

Note it does assume both keys and values are comparable so will give you the property you need.

Good idea. The pom.xml changes are to accommodate this.

---

projects/question/src/main/java/org/batfish/question/UniqueBgpAsnQuestionPlugin.java, line 109 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

bf_answer("UniqueBgpAsns", nodeRegex='as2.*')

what is this?

legacy; auto-generating docs: https://github.com/batfish/batfish/wiki/Questions. We don't do that anymore. I left it there for consistency; we can go in and remove from everywhere.

---

Comments from Reviewable

[dhalperi]

Reviewed 8 of 8 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

projects/pom.xml, line 532 at r2 (raw file):

jackson-datatype-guava

Per the documentation, this library is deprecated. Use jackson-datatype-collections instead and then you can just use jackson.version.

---

projects/question/src/main/java/org/batfish/question/BgpAsnUseQuestionPlugin.java, line 102 at r2 (raw file):

   *
   * @type BgpAsnUse multifile
   * @param minCount Only report ASNs that are used at more than this number of nodes

suspect that > will be confusing for something called minCount -- it should be >=.

Either change name or semantics.. having a hard time thinking of a better name, so change semantics and switch number in the test?

---

Comments from Reviewable

[ratulm]

Review status: 2 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

projects/pom.xml, line 532 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

jackson-datatype-guava

Per the documentation, this library is deprecated. Use jackson-datatype-collections instead and then you can just use jackson.version.

Done.

---

projects/question/src/main/java/org/batfish/question/BgpAsnUseQuestionPlugin.java, line 102 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

suspect that > will be confusing for something called minCount -- it should be >=.

Either change name or semantics.. having a hard time thinking of a better name, so change semantics and switch number in the test?

Changed semantics.

---

Comments from Reviewable

[dhalperi]

---

Reviewed 2 of 8 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable