Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: if name is not provided, use a transient name #186

Merged
merged 2 commits into from Nov 6, 2018

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Nov 5, 2018

Starting with __

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dhalperi and @progwriter)

a discussion (no related file):
Needs a test - any advice?


Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dhalperi and @progwriter)

a discussion (no related file):

Previously, dhalperi (Dan Halperin) wrote…

Needs a test - any advice?

Use a very simple inline template in a unit test and then _load_question_dict to avoid mucking with meta classes would be my suggestion.


Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved

a discussion (no related file):

Previously, progwriter (Victor Heorhiadi) wrote…

Use a very simple inline template in a unit test and then _load_question_dict to avoid mucking with meta classes would be my suggestion.

Done.


Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 386d037 into batfish:master Nov 6, 2018
@dhalperi dhalperi deleted the question-transient-name branch November 6, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants