Interface stringification

[ratulm]

No description provided.

[batfish-bot]

This change is 

[dhalperi]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @progwriter and @ratulm)

a discussion (no related file):
@arifogel has some design for this that is intended to handle this and a whole slew of other issues. There's a huge amount of complication in doing this right; this PR should not go in on its own without that complexity accounted for.

---

[ratulm]

@arifogel - is there a doc i can look at? else, lets chat offline.

[arifogel]

Reviewed 3 of 5 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ratulm)

---

pybatfish/util.py, line 43 at r2 (raw file):

# Characters that must be escaped in name
# Should be in sync with SPECIAL_CHARS in CommonParser.java
_NAME_SPECIAL_CHARS_ = " \t,\\&()[]@" + "!#$%^;?<>={}"

Why is this split?

[ratulm]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @arifogel and @ratulm)

---

pybatfish/util.py, line 43 at r2 (raw file):

Previously, arifogel (Ari Fogel) wrote…

Why is this split?

To exactly mirror the Java definition. (It is that way in Java because the first set of characters is being actively used and the second set is reserved for future use.)

[dhalperi]

a discussion (no related file):

Previously, dhalperi (Dan Halperin) wrote…

@arifogel has some design for this that is intended to handle this and a whole slew of other issues. There's a huge amount of complication in doing this right; this PR should not go in on its own without that complexity accounted for.

Unblocking myself now that you're talking :)

---

[arifogel]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[arifogel]

Reviewed 6 of 6 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[arifogel]

Reviewable status: complete! all files reviewed, all discussions resolved