CI: black requires we use C.UTF-8 encoding #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 84.97% 84.97%
=======================================
Files 30 30
Lines 3588 3588
Branches 564 564
=======================================
Hits 3049 3049
Misses 405 405
Partials 134 134 |
ratulm
reviewed
May 12, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI failures like this:
https://buildkite.com/batfish/pybatfish-pre-commit/builds/21575#b76894ea-1cae-4eb7-ac7a-1565d916fe4c/101-143
I'm just following the recommendation from the error message. Maybe there's a better way (or place?) to do this.
More info: https://click.palletsprojects.com/en/8.0.x/unicode-support/