Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making assignment expression a bit more permissive #18

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

aziz
Copy link
Collaborator

@aziz aziz commented Nov 5, 2016

fixes #16 and #17

@bathos
Copy link
Owner

bathos commented Nov 5, 2016

Awesome! Much appreciated. While I’d rather not make AE more permissive in this way (because the real problems are more specific, and I think this kills off recognition of sequences like if () {} as invalid), I’m gonna merge as-is cause (as you’ve probably noticed) I haven’t had time lately to address these issues myself.

@bathos bathos merged commit cc5020a into bathos:master Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX comments bug
2 participants