Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean upload file names #146

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Conversation

remik
Copy link
Collaborator

@remik remik commented Jun 1, 2016

I also removed six.u() because it is working wrong on Python2 (there is a note: https://pythonhosted.org/six/index.html#six.u) eg. "АБВГДЕЖ.pdf" was converted to "Ð�Ð�Ð�Ð�Ð�Ð�Ð�.pdf".
Python 3.3 bring back support for u"" and Python 3.0-3.2 is no more supported.

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.06%) to 90.83% when pulling 5b1f8d5 on remik:feature/clean-filename into c91022b on batiste:master.

@batiste
Copy link
Owner

batiste commented Jun 1, 2016

Great.
When you are at it could you add a few test cases:

filewithoutextension
filewith.two.extension
file<with></script>"'</script>malicious

@batiste batiste merged commit a764c83 into batiste:master Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants