update-rotate-mappings-dolphin [V41] #12077
Merged
+21
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you explain why we had clockwise & counter-clockwise before? |
Initially having the ES setting to rotate face mappings for GC was to resolve issue with users that preferred the legacy mapping where the GC mappings were more in line with cardinal direction (GC A being South). I had added the ability to rotate counter clock wise as a just in case option, but no one even has used it (GC A being North). So this PR aims to remove the unused setting and then simplify things further by making it a toggle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused rotate face buttons counter-clockwise and changes to simple switch toggle. Updated setting name and description for better clarity.