Merge pull request #412 from jjdiazgarcia/fix/missing_function_pretty…

…_formatter

Fix missing function in pretty formatter

docs/CHANGELOG.md

@@ -10,6 +10,11 @@ The format is based on [Keep a Changelog][kac] and this project adheres to
 
 ## [Unreleased]
 
+### Fixed
+
+* fix `bats_tap_stream_unknown: command not found` with pretty formatter, when
+  writing non compliant extended output (#412)
+
 ## [1.3.0] - 2021-03-08
 
 ### Added

docs/source/docker-usage.md

@@ -18,21 +18,21 @@ Receiving objects: 100% (1222/1222), 327.28 KiB | 1.70 MiB/s, done.
 Resolving deltas: 100% (661/661), done.
 
 $ cd bats-core/
-$ docker build --tag bats:latest .
+$ docker build --tag bats/bats:latest .
 ...
-$ docker run -it bats:latest --formatter tap /opt/bats/test
+$ docker run -it bats/bats:latest --formatter tap /opt/bats/test
 ```
 
 To mount your tests into the container, first build the image as above. Then, for example with `bats`:
 ```bash
-$ docker run -it -v "$PWD:/opt/bats" bats:latest /opt/bats/test
+$ docker run -it -v "$PWD:/opt/bats" bats/bats:latest /opt/bats/test
 ```
 This runs the `test/` directory from the bats-core repository inside the bats Docker container.
 
 For test suites that are intended to run in isolation from the project (i.e. the tests do not depend on project files outside of the test directory), you can mount the test directory by itself and execute the tests like so:
 
 ```bash
-$ docker run -it -v "$PWD/test:/test" bats:latest /test
+$ docker run -it -v "$PWD/test:/test" bats/bats:latest /test
 ```
 
 ## Docker Gotchas
@@ -46,7 +46,7 @@ Relying on functionality provided by your environment (ssh keys or agent, instal
 Docker operates on a principle of isolation, and bundles all dependencies required into the Docker image. These can be mounted in at runtime (for test files, configuration, etc). For binary dependencies it may be better to extend the base Docker image with further tools and files.
 
 ```dockerfile
-FROM bats
+FROM bats/bats
 
 RUN \ 
   apk \

libexec/bats-core/bats-format-pretty

@@ -195,7 +195,7 @@ bats_tap_stream_begin() {
   begin
   flush
 }
-  
+
 bats_tap_stream_ok() {
   index="$1"
   ((++passed))
@@ -230,6 +230,10 @@ bats_tap_stream_suite() {
   : #test_file="$1"
 }
 
+bats_tap_stream_unknown() { # <full line>
+    printf "%s\n" "$1"
+}
+
 bats_parse_internal_extended_tap
 
 summary

test/bats.bats

@@ -734,4 +734,30 @@ END_OF_ERR_MSG
 
   # should also find preprocessed files!
   [ $(find "$TEST_TMPDIR" -name '*.src' | wc -l) -eq 1 ]
+}
+
+@test "All formatters (except cat) implement the callback interface" {
+  cd "$BATS_ROOT/libexec/bats-core/"
+  for formatter in bats-format-*; do
+    # the cat formatter is not expected to implement this interface
+    if [[ "$formatter" == *"bats-format-cat" ]]; then
+      continue
+    fi
+    tested_at_least_one_formatter=1
+    echo "Formatter: ${formatter}"
+    # the replay should be possible without errors
+    "$formatter" >/dev/null <<EOF
+1..1
+suite "$BATS_FIXTURE_ROOT/failing.bats"
+begin 1 test_a_failing_test
+not ok 1 a failing test
+# (in test file test/fixtures/bats/failing.bats, line 4)
+#   \`eval "( exit ${STATUS:-1} )"' failed
+begin 2 test_a_successful_test
+ok 2 a succesful test
+unknown line
+EOF
+  done
+
+  [[ -n "$tested_at_least_one_formatter" ]]
 }