Cleanup run interface #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-schulze-vireso
force-pushed
the
fix/use_-N_for_run_return_code_checks
branch
from
e349ef7
to
f7cf9a1
Compare
Reading only stderr/stdout can be achieved by the separation as well. Performance did not differ much. We can still revive these options later on but taking them back won't be possible.
martin-schulze-vireso
force-pushed
the
fix/use_-N_for_run_return_code_checks
branch
from
f7cf9a1
to
f69c26d
Compare
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jul 31, 2022
Bats 1.7.0 emits a warning if a command passed to 'run' returns with an
exit code of 127 [1].
This requires Bats >= 1.5.0, which is present in Fedora >=35, and
supports specifying the exit code as an argument to Bats' 'run'
command [2].
However, bats_require_minimum_version can't be used, because it's
only available from Bats 1.7.0, which is new enough that it's absent in
Fedora 35.
[1] Bats commit c6dc2f88361a4f5b
bats-core/bats-core#547
https://bats-core.readthedocs.io/en/stable/warnings/BW01.html
[2] bats-core/bats-core#367
bats-core/bats-core#507
https://bats-core.readthedocs.io/en/stable/writing-tests.html
[3] Bats commit 71d6b71cebc3d32b
bats-core/bats-core#556
https://bats-core.readthedocs.io/en/stable/warnings/BW02.html
containers#1081
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Aug 1, 2022
Bats 1.7.0 emits a warning if a command passed to 'run' returns with an
exit code of 127 [1]:
BW01: `run`'s command `/opt/bin/toolbox run non-existent-command`
exited with code 127, indicating 'Command not found'. Use run's
return code checks, e.g. `run -127`, to fix this message.
(from function `run' in file
/usr/lib/bats-core/test_functions.bash, line 299,
in test file test/system/104-run.bats, line 148)
This requires Bats >= 1.5.0, which is present in Fedora >=35, and
supports specifying the exit code as an argument to Bats' 'run'
command [2].
However, bats_require_minimum_version can't be used, because it's
only available from Bats 1.7.0, which is new enough that it's absent
from Fedora 35.
[1] Bats commit c6dc2f88361a4f5b
bats-core/bats-core#547
https://bats-core.readthedocs.io/en/stable/warnings/BW01.html
[2] bats-core/bats-core#367
bats-core/bats-core#507
https://bats-core.readthedocs.io/en/stable/writing-tests.html
[3] Bats commit 71d6b71cebc3d32b
bats-core/bats-core#556
https://bats-core.readthedocs.io/en/stable/warnings/BW02.html
containers#1081
nievesmontero
pushed a commit
to nievesmontero/toolbox
that referenced
this pull request
Aug 24, 2022
Bats 1.7.0 emits a warning if a command passed to 'run' returns with an
exit code of 127 [1]:
BW01: `run`'s command `/opt/bin/toolbox run non-existent-command`
exited with code 127, indicating 'Command not found'. Use run's
return code checks, e.g. `run -127`, to fix this message.
(from function `run' in file
/usr/lib/bats-core/test_functions.bash, line 299,
in test file test/system/104-run.bats, line 148)
This requires Bats >= 1.5.0, which is present in Fedora >=35, and
supports specifying the exit code as an argument to Bats' 'run'
command [2].
However, bats_require_minimum_version can't be used, because it's
only available from Bats 1.7.0, which is new enough that it's absent
from Fedora 35.
[1] Bats commit c6dc2f88361a4f5b
bats-core/bats-core#547
https://bats-core.readthedocs.io/en/stable/warnings/BW01.html
[2] bats-core/bats-core#367
bats-core/bats-core#507
https://bats-core.readthedocs.io/en/stable/writing-tests.html
[3] Bats commit 71d6b71cebc3d32b
bats-core/bats-core#556
https://bats-core.readthedocs.io/en/stable/warnings/BW02.html
containers#1081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479
=<N>to `---output <option>with--separate-stderr