Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fizzle Snapshot Card order #35

Open
G333h opened this issue Apr 15, 2024 · 7 comments
Open

Fizzle Snapshot Card order #35

G333h opened this issue Apr 15, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@G333h
Copy link

G333h commented Apr 15, 2024

Hello !
First, thanks for this plugin, this is what I was looking for fizzle snapshot on HDT, since it's natively missing :)
But I noticed cards in fizzle snapshot are in a random order, would it be possible for you to modify it so they are showing in the correct order (from the left to the right in the hand at the moment where it's snapshoted)

Best regards, Thanks

@batstyx batstyx added the enhancement New feature or request label Apr 16, 2024
batstyx added a commit that referenced this issue Apr 16, 2024
- From: Hand default order (chronological?)
- To: Hand zone position order
- See #35
@batstyx
Copy link
Owner

batstyx commented Apr 16, 2024

I played exactly one game to test this change, so good luck to you :)

@G333h
Copy link
Author

G333h commented Apr 16, 2024

Hello, thanks !

tested it, it nearly worked as intented, cards are in correct order except when you have 2 copy of a card in the hand, it will group them together.

example with 2 conductivity in my hand

here the correct order was :
Novice zapper / kobold geomancer / Bloodmage / conductivity / Flash of lightning / conductivity / crash of thunder / pop-up book
and it shows on the plugin
Novice zapper / kobold geomancer / Bloodmage / conductivity / conductivity / Flash of lightning / crash of thunder / pop-up book

fizzle

@batstyx
Copy link
Owner

batstyx commented Apr 16, 2024

I really hoped that simple addition would do it. I could have sworn I had duplicate cards correctly ordered in the test I did but the screenshot didn't save for some reason so I can't check.
Apart from Demon Hunter Outcast cards, I'm assuming this is mainly a cosmetic annoyance?

@G333h
Copy link
Author

G333h commented Apr 17, 2024

Hello !
Sadly, no, it's not cosmetic, order is really important, because you don't often have all the room in your hand to get every card from the snapshot.
If I have 8 cards on my snapshot but only 5 spot on my hand and need a precise card which show on 5th spot in the list but is in reality on the 6th spot, it can instantly loose the game.

@batstyx
Copy link
Owner

batstyx commented Apr 18, 2024

Oops. I do, ofc, "know" this, but I'd forgotten. I don't think I've ever played a tight enough strategy that I've lost this way!
If I get the time I'll take a further look at this. It may be I'm using the HDT API wrong. However if it's an HDT bug then, unless it's straightforward, it's well above my pay grade.

@batstyx batstyx reopened this Apr 18, 2024
@G333h
Copy link
Author

G333h commented Apr 18, 2024

True, it's for some specific deck/strategy,I admit, it's not for every game :)
Thanks, it's allready awesome that you improve the order !

@batstyx
Copy link
Owner

batstyx commented May 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants