Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immortal Lifetime logic is… odd #3

Open
battis opened this issue Aug 18, 2016 · 0 comments
Open

Immortal Lifetime logic is… odd #3

battis opened this issue Aug 18, 2016 · 0 comments
Labels

Comments

@battis
Copy link
Owner

battis commented Aug 18, 2016

Right now, you can only look up cached values that have IMMORTAL_LIFETIME if the SimpleCache object has had its lifetime set explicitly to IMMORTAL_LIFETIME. This is dumb and stupid. Setting the cache object lifetime should affect the default lifetime of newly cached data, but the the expiration dates of currently cached data should be all that limits getCache() responses -- and data with perfectly good immortal lifetimes should be found!

N.B. that it is possible that changing this logic will necessitate dramatic version number increases. Think carefully!

@battis battis added the bug label Aug 18, 2016
battis pushed a commit to smtech/printable-forms that referenced this issue Aug 18, 2016
I'm inclinded to think that [the logic is borked](battis/simplecache#3) for this, but now it's working. Also, we now have a read me file. And Scrutinizer is watching us!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant