FreeBSD/socket: user cookie socket option support. #38
Conversation
devnexen
force-pushed
the
fbsd_so_user_cookie
branch
from
4c09670
to
3fa820c
Compare
giving here an identifier to the socket for DTrace's context, ipfw filter and so on.
devnexen
force-pushed
the
fbsd_so_user_cookie
branch
from
3fa820c
to
e398e65
Compare
| @@ -76,6 +76,7 @@ int getTcpKeepAliveIntvl(int fd) throws SocketException { | |||
| private static native int getTcpKeepAliveTime0(int fd) throws SocketException; | |||
| private static native int getTcpKeepAliveIntvl0(int fd) throws SocketException; | |||
| private static native boolean keepAliveOptionsSupported0(); | |||
| private static native void setUserCookie(int fd, int cookie) throws SocketException; | |||
There was a problem hiding this comment.
I might have been a bit hasty earlier. Please allow me to make some further comments now that I've had a longer look at it.
A minor comment is that all other native methods in this class end with 0. This is mostly because the non-native versions of the methods which call them take up the same name without the 0, but I think it's reasonable to want to be consistent. However, this leads me to the larger concern.
The method you're adding here is a private method. Since it isn't exposed through the public methods of the class it can never be called (other than internally, which is not done in this change). I question the value of adding code that can't actually be called (note that I am ignoring byte manipulation hacks that some mocking packages, for instance, employ that might allow that). Note that I'm not suggesting here that you immediately go and add a public method to call into this. What I'm suggesting is a discussion of how developers may want to utilise this and what changes might make sense to allow for that.
There was a problem hiding this comment.
Yes in fact I wanted to test the "appeal" of this idea first and also to see if this is better to call it indirectly from another higher java class or since it is pretty "unique feature" to make it simply public finally...
giving here an identifier to the socket for DTrace's context,
ipfw filter and so on.