Search Pagination! #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsegaran
reviewed
Nov 4, 2018
|
Left one comment. For me when testing locally. It displayed all of the search results on the same page then had non-functional buttons. I don't know if this was happening because the prod server is serving pages of size 200 instead of 10. |
kelvin-lu
force-pushed
the
kelvinlu/pagination
branch
from
2610db0
to
ca0ca9a
Compare
arvid220u
pushed a commit
that referenced
this pull request
Jul 29, 2019
Pagination support for the search page. And some style updates for the search page.
arvid220u
pushed a commit
that referenced
this pull request
Jul 29, 2019
Pagination support for the search page. And some style updates for the search page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagination support for the search page. And some style updates for the search page.